linux-kernel - Re: [PATCH] xen/manage: don't complain about an empty value in control/sysrq node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180906130016.3nu6zvitjci7x5ge@zion.uk.xensource.com>
Date:   Thu, 6 Sep 2018 14:00:16 +0100
From:   Wei Liu <wei.liu2@...rix.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
CC:     <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>, Wei Liu <wei.liu2@...rix.com>
Subject: Re: [PATCH] xen/manage: don't complain about an empty value in
 control/sysrq node

On Thu, Sep 06, 2018 at 01:26:08PM +0200, Vitaly Kuznetsov wrote:
> When guest receives a sysrq request from the host it acknowledges it by
> writing '\0' to control/sysrq xenstore node. This, however, make xenstore
> watch fire again but xenbus_scanf() fails to parse empty value with "%c"
> format string:
> 
>  sysrq: SysRq : Emergency Sync
>  Emergency Sync complete
>  xen:manage: Error -34 reading sysrq code in control/sysrq
> 
> Ignore -ERANGE the same way we already ignore -ENOENT, empty value in
> control/sysrq is totally legal.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Reviewed-by: Wei Liu <wei.liu2@...rix.com>