linux-kernel - Re: [PATCH V3 09/26] csky: VDSO and rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2z2=0qNWZft6rokx0i=8E5ZbEg1WL5HMYg_DE1wPvZQw@mail.gmail.com>
Date:   Thu, 6 Sep 2018 16:02:42 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Guo Ren <ren_guo@...ky.com>
Cc:     linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Jason Cooper <jason@...edaemon.net>,
        c-sky_gcc_upstream@...ky.com, gnu-csky@...tor.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        wbx@...ibc-ng.org, Greentime Hu <green.hu@...il.com>
Subject: Re: [PATCH V3 09/26] csky: VDSO and rt_sigreturn

On Wed, Sep 5, 2018 at 2:08 PM Guo Ren <ren_guo@...ky.com> wrote:

> +
> +       /*
> +        * __NR_rt_sigreturn must be 173
> +        * Because gcc/config/csky/linux-unwind.h use hard code to parse rt_sigframe.
> +        */
> +       err = setup_vdso_page(vdso->rt_signal_retcode);
> +       if (err) panic("Cannot set signal return code, err: %x.", err);

__NR_rt_sigreturn is 139

I think you need to update the comment, and probably check your gcc sources
to ensure it still does the right thing.

         Arnd