linux-kernel - Re: [PATCH v2] HID: i2c-hid: Don't reset device upon system resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1809061631250.15880@cbobk.fhfr.pm>
Date:   Thu, 6 Sep 2018 16:32:26 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
cc:     benjamin.tissoires@...hat.com, hdegoede@...hat.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Aaron Ma <aaron.ma@...onical.com>,
        AceLan Kao <acelan.kao@...onical.com>
Subject: Re: [PATCH v2] HID: i2c-hid: Don't reset device upon system resume

On Thu, 6 Sep 2018, Kai-Heng Feng wrote:

> Raydium touchscreen triggers interrupt storm after system-wide suspend:
> [ 179.085033] i2c_hid i2c-CUST0000:00: i2c_hid_get_input: incomplete
> report (58/65535)
> 
> According to Raydium, Windows driver does not reset the device after
> system resume.
> 
> The HID over I2C spec does specify a reset should be used at
> intialization, but it doesn't specify if reset is required for system
> suspend.
> 
> Tested this patch on other i2c-hid touchpanels I have and those
> touchpanels do work after S3 without doing reset. If any regression
> happens to other touchpanel vendors, we can use quirk for Raydium
> devices.
> 
> There's still one device uses I2C_HID_QUIRK_RESEND_REPORT_DESCR so keep
> it there.
> 
> Cc: Aaron Ma <aaron.ma@...onical.com>
> Cc: AceLan Kao <acelan.kao@...onical.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Queued in for-4.19/fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs