linux-kernel - Re: [PATCH] btrfs: remove unused pointer 'tree'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180906160827.GE24025@twin.jikos.cz>
Date:   Thu, 6 Sep 2018 18:08:27 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: remove unused pointer 'tree'

On Tue, Aug 28, 2018 at 02:21:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer 'tree' is being assigned but is never used hence it is
> redundant and can be removed.

For patches removing dead code it's good to do a bit of research what
was the reason for that. In most cases it's a simple leftover after some
other cleanup or rework, ie. harmless, but this needs to be reviewed
anyway and the reference in changelog helps.

In this case it's after my commit 00032d38eaa89c76de7, I'll update the
changelog. And the previous patch removing inode in relink_file_extents
was udpated too.
> 
> Cleans up clang warning:
> warning: variable 'tree' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: David Sterba <dsterba@...e.com>