linux-kernel - Re: [PATCH 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XDz9t8mWBrCSUMAgaxwhwLiv86zTyekG0=ybGQ1f73Yg@mail.gmail.com>
Date:   Thu, 6 Sep 2018 09:33:29 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Girish Mahadevan <girishm@...eaurora.org>,
        Dilip Kota <dkota@...eaurora.org>,
        Evan Green <evgreen@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        David Brown <david.brown@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors
 in geni_se_clk_tbl_get()

Hi,

On Wed, Sep 5, 2018 at 4:37 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
>>  int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl)
>>  {
>> -     unsigned long freq = 0;
>> +     long freq = 0;
>
> nit: Since you are already touching this you could also remove the
> pointless initialization, 'freq' is always assigned before it is used.

Done.

-Doug