linux-kernel - [PATCH 4.18 090/145] ALSA: ac97: fix check of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  7 Sep 2018 23:09:16 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Lihua Yao <ylhuajnu@....com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Takashi Iwai <tiwai@...e.de>
Subject: [PATCH 4.18 090/145] ALSA: ac97: fix check of pm_runtime_get_sync failure

4.18-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Lihua Yao <ylhuajnu@....com>

commit d15ec0b482ff502e4e19e43d15aa5072e4290199 upstream.

pm_runtime_get_sync returns negative on failure.

Fixes: 74426fbff66e ("ALSA: ac97: add an ac97 bus")
Signed-off-by: Lihua Yao <ylhuajnu@....com>
Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>
Cc: <stable@...r.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@...e.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 sound/ac97/bus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -503,7 +503,7 @@ static int ac97_bus_remove(struct device
 	int ret;
 
 	ret = pm_runtime_get_sync(dev);
-	if (ret)
+	if (ret < 0)
 		return ret;
 
 	ret = adrv->remove(adev);