linux-kernel - Re: [LKP] 0a3856392c [ 10.513760] INFO: trying to register non-static key.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180907021937.GA7440@bombadil.infradead.org>
Date:   Thu, 6 Sep 2018 19:19:37 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     kernel test robot <rong.a.chen@...el.com>
Cc:     linux-kernel@...r.kernel.org, LKP <lkp@...org>
Subject: Re: [LKP] 0a3856392c [   10.513760] INFO: trying to register
 non-static key.

On Fri, Sep 07, 2018 at 09:05:39AM +0800, kernel test robot wrote:
> Greetings,
> 
> 0day kernel testing robot got the below dmesg and the first bad commit is
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> 
> commit 0a3856392cff1542170b5bc37211c9a21fd0c3f6
> Author:     Matthew Wilcox <willy@...radead.org>
> AuthorDate: Mon Jun 18 17:23:37 2018 -0400
> Commit:     Matthew Wilcox <willy@...radead.org>
> CommitDate: Tue Aug 21 23:54:20 2018 -0400
> 
>     test_ida: Move ida_check_leaf
>     
>     Convert to new API and move to kernel space.  Take the opportunity to
>     test the situation a little more thoroughly (ie at different offsets).
>     
>     Signed-off-by: Matthew Wilcox <willy@...radead.org>

Thank you test-bot.  Can you check if this patch fixes the problem?

diff --git a/lib/test_ida.c b/lib/test_ida.c
index 2d1637d8136b..b06880625961 100644
--- a/lib/test_ida.c
+++ b/lib/test_ida.c
@@ -150,10 +150,10 @@ static void ida_check_conv(struct ida *ida)
 	IDA_BUG_ON(ida, !ida_is_empty(ida));
 }
 
+static DEFINE_IDA(ida);
+
 static int ida_checks(void)
 {
-	DEFINE_IDA(ida);
-
 	IDA_BUG_ON(&ida, !ida_is_empty(&ida));
 	ida_check_alloc(&ida);
 	ida_check_destroy(&ida);