linux-kernel - Re: [PATCH v2 1/8] perf/x86: add a function to get the lbr stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180907032811.GO27886@tassilo.jf.intel.com>
Date:   Thu, 6 Sep 2018 20:28:11 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Wei Wang <wei.w.wang@...el.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        pbonzini@...hat.com, kan.liang@...el.com, peterz@...radead.org,
        mingo@...hat.com, rkrcmar@...hat.com, like.xu@...el.com
Subject: Re: [PATCH v2 1/8] perf/x86: add a function to get the lbr stack

> +int perf_get_lbr_stack(struct perf_lbr_stack *stack)
> +{
> +	stack->lbr_nr = x86_pmu.lbr_nr;
> +	stack->lbr_tos = x86_pmu.lbr_tos;
> +	stack->lbr_from = x86_pmu.lbr_from;
> +	stack->lbr_to = x86_pmu.lbr_to;
> +
> +	if (x86_pmu.intel_cap.lbr_format == LBR_FORMAT_INFO)
> +		stack->lbr_info = MSR_LBR_INFO_0;
> +	else
> +		stack->lbr_info = 0;

Seems weird to export the enum value if the enum isn't exported.
How can it be used?

-Andi