lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Sep 2018 07:43:35 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Sasha Levin <Alexander.Levin@...rosoft.com> Cc: "stable@...r.kernel.org" <stable@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sebastian Andrzej Siewior <bigeasy@...utronix.de> Subject: Re: [PATCH AUTOSEL 4.9 01/43] usb: usbtest: use irqsave() in USB's complete callback On Fri, Sep 07, 2018 at 12:38:19AM +0000, Sasha Levin wrote: > From: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > > [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ] > > The USB completion callback does not disable interrupts while acquiring > the lock. We want to remove the local_irq_disable() invocation from > __usb_hcd_giveback_urb() and therefore it is required for the callback > handler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave() variant of the locking primitives. > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Acked-by: Alan Stern <stern@...land.harvard.edu> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com> > --- > drivers/usb/misc/usbtest.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) And dropped here :)
Powered by blists - more mailing lists