linux-kernel - Re: [Xen-devel] [PATCH] xen/balloon: add runtime control for scrubbing ballooned out pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5B921FEE02000078001E6258@prv1-mh.provo.novell.com>
Date:   Fri, 07 Sep 2018 00:51:26 -0600
From:   "Jan Beulich" <JBeulich@...e.com>
To:     "Marek Marczykowski" <marmarek@...isiblethingslab.com>
Cc:     "xen-devel" <xen-devel@...ts.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
        "Juergen Gross" <jgross@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/balloon: add runtime control for
 scrubbing ballooned out pages

>>> On 06.09.18 at 17:33, <marmarek@...isiblethingslab.com> wrote:
> --- a/include/xen/mem-reservation.h
> +++ b/include/xen/mem-reservation.h
> @@ -17,12 +17,17 @@
>  
>  #include <xen/page.h>
>  
> +#ifdef CONFIG_XEN_SCRUB_PAGES
> +extern bool xen_scrub_pages;
> +
>  static inline void xenmem_reservation_scrub_page(struct page *page)
>  {
> -#ifdef CONFIG_XEN_SCRUB_PAGES
> -	clear_highpage(page);
> -#endif
> +	if (xen_scrub_pages)
> +		clear_highpage(page);
>  }
> +#else
> +static inline void xenmem_reservation_scrub_page(struct page *page) { }
> +#endif

Wouldn't CONFIG_XEN_SCRUB_PAGES then better become
CONFIG_XEN_SCRUB_PAGES_DEFAULT, with the value used as
initializer of xen_scrub_pages?

Jan