linux-kernel - Re: [PATCH v3] xen: avoid crash in disable_hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Sep 2018 11:24:51 +0200
From:   Olaf Hering <olaf@...fle.de>
To:     Juergen Gross <jgross@...e.com>
Cc:     xen-devel@...ts.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] xen: avoid crash in disable_hotplug_cpu

Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <jgross@...e.com>:

> On 07/09/18 08:30, Olaf Hering wrote:
> > +	if (cpu_online(cpu))
> > +		return;
> >  	if (cpu_present(cpu))
> >  		xen_arch_unregister_cpu(cpu);  

> Could you merge the two if conditions?
> if (!cpu_online(cpu) && cpu_present(cpu))
> 	xen_arch_unregister_cpu(cpu);

Is that any different, beside being wrong, from what the patch actually does?
It would still clear the present bit later on.

Olaf

Content of type "application/pgp-signature" skipped