linux-kernel - Re: [PATCH] mfd: ti-lmu: constify mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Sep 2018 11:39:54 +0200
From:   Pavel Machek <pavel@....cz>
To:     kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, tony@...mide.com, sre@...nel.org,
        nekit1000@...il.com, mpartap@....net, merlijn@...zup.org,
        lee.jones@...aro.org
Subject: Re: [PATCH] mfd: ti-lmu: constify mfd_cell tables

On Wed 2018-08-29 11:31:08, Pavel Machek wrote:
> From: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> 
> mfd: ti-lmu: constify mfd_cell tables
>     
> Add const attribute to all mfd_cell structures.
>     
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> Signed-off-by: Pavel Machek <pavel@....cz>

Lee, I guess this is for you to apply. Any news there?

There are more patches ready,

https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19

and it would be good to get them in. (Alternatively, you can just
cherry-pick them from droid4-pending-v4.19).

Thanks,
							Pavel
							

> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
> index cfb411c..990437e 100644
> --- a/drivers/mfd/ti-lmu.c
> +++ b/drivers/mfd/ti-lmu.c
> @@ -25,7 +25,7 @@
>  #include <linux/slab.h>
>  
>  struct ti_lmu_data {
> -	struct mfd_cell *cells;
> +	const struct mfd_cell *cells;
>  	int num_cells;
>  	unsigned int max_register;
>  };
> @@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
>  		gpio_set_value(lmu->en_gpio, 0);
>  }
>  
> -static struct mfd_cell lm3532_devices[] = {
> +static const struct mfd_cell lm3532_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3532,
> @@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
>  	.of_compatible = "ti,lm363x-regulator",	\
>  }						\
>  
> -static struct mfd_cell lm3631_devices[] = {
> +static const struct mfd_cell lm3631_devices[] = {
>  	LM363X_REGULATOR(LM3631_BOOST),
>  	LM363X_REGULATOR(LM3631_LDO_CONT),
>  	LM363X_REGULATOR(LM3631_LDO_OREF),
> @@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
>  	},
>  };
>  
> -static struct mfd_cell lm3632_devices[] = {
> +static const struct mfd_cell lm3632_devices[] = {
>  	LM363X_REGULATOR(LM3632_BOOST),
>  	LM363X_REGULATOR(LM3632_LDO_POS),
>  	LM363X_REGULATOR(LM3632_LDO_NEG),
> @@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
>  	},
>  };
>  
> -static struct mfd_cell lm3633_devices[] = {
> +static const struct mfd_cell lm3633_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3633,
> @@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
>  	},
>  };
>  
> -static struct mfd_cell lm3695_devices[] = {
> +static const struct mfd_cell lm3695_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3695,
> @@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
>  	},
>  };
>  
> -static struct mfd_cell lm3697_devices[] = {
> +static const struct mfd_cell lm3697_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3697,
> 



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)