linux-kernel - Re: [PATCH] x86, mm: Reserver some memory for bootmem allocator for NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1809071250240.1402@nanos.tec.linutronix.de>
Date:   Fri, 7 Sep 2018 12:52:17 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Feng Tang <feng.tang@...el.com>
cc:     Michal Hocko <mhocko@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Ingo Molnar <mingo@...e.hu>,
        "H . Peter Anvin" <hpa@...ux.intel.com>,
        Yinghai Lu <yinghai@...nel.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] x86, mm: Reserver some memory for bootmem allocator for
 NO_BOOTMEM

On Fri, 7 Sep 2018, Feng Tang wrote:
> On Fri, Aug 31, 2018 at 09:36:59PM +0800, Feng Tang wrote:
> > Any sugestion? I can only have patch like this:
> 
> Could you review this patch, as at this time window there is no usable memory
> block or other memory allocators that I know, so I follow the exisitng static
> fixmap page table code and add one more.

You really want to add a proper sanity check for this. The static stuff has
to cover the fixmap. Just making it work for this particular case is sloppy
at best as the next larger change of the fixmap will just bring the problem
back.

Thanks,

	tglx