lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Sep 2018 00:37:45 +0000 From: Sasha Levin <Alexander.Levin@...rosoft.com> To: "stable@...r.kernel.org" <stable@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: Anton Vasilyev <vasilyev@...ras.ru>, Aleksandar Markovic <aleksandar.markovic@...s.com>, Miodrag Dinic <miodrag.dinic@...s.com>, Goran Ferenc <goran.ferenc@...s.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Sasha Levin <Alexander.Levin@...rosoft.com> Subject: [PATCH AUTOSEL 4.14 33/67] video: goldfishfb: fix memory leak on driver remove From: Anton Vasilyev <vasilyev@...ras.ru> [ Upstream commit 5958fde72d04e7b8c6de3669d1f794a90997e3eb ] goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does not have deallocation of fb, which leads to memory leak on probe/remove. The patch adds deallocation into goldfish_fb_remove(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev <vasilyev@...ras.ru> Cc: Aleksandar Markovic <aleksandar.markovic@...s.com> Cc: Miodrag Dinic <miodrag.dinic@...s.com> Cc: Goran Ferenc <goran.ferenc@...s.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com> --- drivers/video/fbdev/goldfishfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c index 7f6c9e6cfc6c..14a93cb21310 100644 --- a/drivers/video/fbdev/goldfishfb.c +++ b/drivers/video/fbdev/goldfishfb.c @@ -301,6 +301,7 @@ static int goldfish_fb_remove(struct platform_device *pdev) dma_free_coherent(&pdev->dev, framesize, (void *)fb->fb.screen_base, fb->fb.fix.smem_start); iounmap(fb->reg_base); + kfree(fb); return 0; } -- 2.17.1
Powered by blists - more mailing lists