linux-kernel - Re: [PATCH] ASoC: max98373: usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Sep 2018 13:11:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Grant Grundler <grundler@...omium.org>
Cc:     Ryan Lee <ryans.lee@...imintegrated.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
> Commit ca917f9fe1a0fab added use of usleep_range() but not
> the corresponding "include <linux/delay.h>". The result is
> with Chrome OS won't build because warnings are forced
> to be errors:
> mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration]
>         usleep_range(10000, 11000);
>         ^

Note that this isn't causing a warning upstream, presumably due to an
implicit inclusion that isn't present in the v4.4 kernel that you appear
to be using, or gets missed due to config differences.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)