linux-kernel - Re: [PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Sep 2018 14:37:54 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     sed@...e.fr
Cc:     kgene@...nel.org, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: s3c24xx: Correct SD card write protect detection
 on Mini2440

On Thu, 6 Sep 2018 at 23:27, Cedric Roux <sed@...e.fr> wrote:
>
> The mini2440 computer uses "active high" to signal that the "write protect"
> of the inserted MMC is set. The current code uses the opposite, leading to
> a wrong detection of write protection. The solution is simply to use
> ".wprotect_invert = 1" in the description of the MMC.
>
> Signed-off-by: Cedric Roux <sed@...e.fr>
> ---
>  arch/arm/mach-s3c24xx/mach-mini2440.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
> index 95753e0..4cd8d45 100644
> --- a/arch/arm/mach-s3c24xx/mach-mini2440.c
> +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
> @@ -232,10 +232,11 @@ static struct s3c2410fb_mach_info mini2440_fb_info __initdata = {
>  /* MMC/SD  */
>
>  static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = {
> -   .gpio_detect   = S3C2410_GPG(8),
> -   .gpio_wprotect = S3C2410_GPH(8),
> -   .set_power     = NULL,
> -   .ocr_avail     = MMC_VDD_32_33|MMC_VDD_33_34,
> +       .wprotect_invert = 1,
> +       .gpio_detect   = S3C2410_GPG(8),
> +       .gpio_wprotect = S3C2410_GPH(8),
> +       .set_power     = NULL,
> +       .ocr_avail     = MMC_VDD_32_33|MMC_VDD_33_34,

I see that entire struct has wrong indentation. In such case can you
send a separate patch cleaning it up, prior to introducing new
feature? First patch would be cleanup and second new feature.

While at cleanup you can also get rid of other checkpatch errors, like:
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: space required after that ',' (ctx:VxV)
WARNING: please, no space before tabs
ERROR: trailing whitespace
WARNING: Avoid unnecessary line continuations
ERROR: "foo * bar" should be "foo *bar"
ERROR: space prohibited before that close parenthesis ')'
WARNING: quoted string split across lines
WARNING: printk() should include KERN_<LEVEL> facility level

Best regards,
Krzysztof