linux-kernel - Re: [tip:x86/paravirt] x86/paravirt: Move the pv_irq_ops under the PARAVIRT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180907144939.GA1662@zn.tnic>
Date:   Fri, 7 Sep 2018 16:49:39 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de, jgross@...e.com,
        mingo@...nel.org, hpa@...or.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/paravirt] x86/paravirt: Move the pv_irq_ops under the
 PARAVIRT_XXL umbrella

Hi Jürgen,

On Mon, Sep 03, 2018 at 08:01:40AM -0700, tip-bot for Juergen Gross wrote:
> Commit-ID:  6da63eb241a05b0e676d68975e793c0521387141
> Gitweb:     https://git.kernel.org/tip/6da63eb241a05b0e676d68975e793c0521387141
> Author:     Juergen Gross <jgross@...e.com>
> AuthorDate: Tue, 28 Aug 2018 09:40:24 +0200
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Mon, 3 Sep 2018 16:50:36 +0200
> 
> x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL umbrella
> 
> All of the paravirt ops defined in pv_irq_ops are for Xen PV guests
> or VSMP only. Define them only if CONFIG_PARAVIRT_XXL is set.
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: xen-devel@...ts.xenproject.org
> Cc: virtualization@...ts.linux-foundation.org
> Cc: akataria@...are.com
> Cc: rusty@...tcorp.com.au
> Cc: boris.ostrovsky@...cle.com
> Cc: hpa@...or.com
> Link: https://lkml.kernel.org/r/20180828074026.820-14-jgross@suse.com
> 
> ---
>  arch/x86/include/asm/irqflags.h       | 8 +-------
>  arch/x86/include/asm/paravirt.h       | 6 +++---
>  arch/x86/include/asm/paravirt_types.h | 3 ++-
>  arch/x86/kernel/asm-offsets.c         | 2 +-
>  arch/x86/kernel/asm-offsets_64.c      | 2 +-
>  arch/x86/kernel/paravirt.c            | 2 +-
>  arch/x86/kernel/paravirt_patch_32.c   | 4 ++--
>  arch/x86/kernel/paravirt_patch_64.c   | 4 +++-
>  arch/x86/kernel/vsmp_64.c             | 2 +-
>  9 files changed, 15 insertions(+), 18 deletions(-)

this one is breaking the randconfig builds with the following error
(failure case simplified):

$ make arch/x86/entry/entry_64.o
  DESCEND  objtool
  CALL    scripts/checksyscalls.sh
  AS      arch/x86/entry/entry_64.o
In file included from arch/x86/entry/entry_64.S:33:0:
./arch/x86/include/asm/paravirt.h:938:0: warning: "SAVE_FLAGS" redefined
 #define SAVE_FLAGS(clobbers)                                        \
 
In file included from arch/x86/entry/entry_64.S:32:0:
./arch/x86/include/asm/irqflags.h:127:0: note: this is the location of the previous definition
 #define SAVE_FLAGS(x)  pushfq; popq %rax
 
arch/x86/entry/entry_64.S: Assembler messages:
arch/x86/entry/entry_64.S:624: Error: invalid operands (*UND* and *UND* sections) for `+'
arch/x86/entry/entry_64.S:649: Error: invalid operands (*UND* and *UND* sections) for `+'
arch/x86/entry/entry_64.S:1046: Error: invalid operands (*UND* and *UND* sections) for `+'
arch/x86/entry/entry_64.S:1048: Error: invalid operands (*UND* and *UND* sections) for `+'
arch/x86/entry/entry_64.S:624: Error: invalid operands (*UND* and *ABS* sections) for `/'
arch/x86/entry/entry_64.S:649: Error: invalid operands (*UND* and *ABS* sections) for `/'
arch/x86/entry/entry_64.S:1046: Error: invalid operands (*UND* and *ABS* sections) for `/'
arch/x86/entry/entry_64.S:1048: Error: invalid operands (*UND* and *ABS* sections) for `/'
scripts/Makefile.build:405: recipe for target 'arch/x86/entry/entry_64.o' failed
make[1]: *** [arch/x86/entry/entry_64.o] Error 1
Makefile:1684: recipe for target 'arch/x86/entry/entry_64.o' failed
make: *** [arch/x86/entry/entry_64.o] Error 2

.config attached.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

View attachment ".config" of type "text/plain" (160722 bytes)