linux-kernel - Re: [PATCH] infiniband: nes: add unlikely() to assert()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <811a6feca9fdea2db59ac392a4711cd897f46cc7.camel@redhat.com>
Date:   Fri, 07 Sep 2018 11:13:21 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Leon Romanovsky <leon@...nel.org>,
        Igor Stoppa <igor.stoppa@...il.com>
Cc:     Faisal Latif <faisal.latif@...el.com>,
        Igor Stoppa <igor.stoppa@...wei.com>,
        Chien Tung <chien.tin.tung@...el.com>,
        Roland Dreier <rolandd@...co.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: nes: add unlikely() to assert()

On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote:
> On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote:
> > Typically the assert is expected to not fail.
> 
> This whole assert can be removed.
> 
> > 
> > Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
> > Acked-by: Doug Ledford <dledford@...hat.com>
> 
> Most probably that I missed discussion, but anyway, does this
> "Acked-by" come from internal or external discussion?

This patch was part of a larger series on lkml.  In that context, I
acked it so that the series could be applied by whomever took it (it
didn't belong on rdma-list as a series since only one patch out of some
large number touched rdma files).  Now it is being resent as not part of
a series, but my ack was preserved.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)