linux-kernel - Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATqTh4oxG5uz2Z4gk0J=kXP62UX2r3cP9Kd2aCSTXzTuA@mail.gmail.com>
Date:   Sat, 8 Sep 2018 01:47:24 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Rob Herring <robh@...nel.org>
Cc:     DTML <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Vineet Gupta <vgupta@...opsys.com>,
        Russell King <linux@...linux.org.uk>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Michal Simek <monstr@...str.eu>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Ley Foon Tan <lftan@...era.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        arcml <linux-snps-arc@...ts.infradead.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:H8/300 ARCHITECTURE" 
        <uclinux-h8-devel@...ts.sourceforge.jp>,
        Linux-MIPS <linux-mips@...ux-mips.org>,
        nios2-dev@...ts.rocketboards.org,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        linux-xtensa@...ux-xtensa.org
Subject: Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

Hi Rob,

2018-09-07 21:17 GMT+09:00 Rob Herring <robh@...nel.org>:
> On Fri, Sep 7, 2018 at 5:33 AM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
>>
>> 2018-09-06 8:53 GMT+09:00 Rob Herring <robh@...nel.org>:
>> > There is nothing arch specific about building dtb files other than their
>> > location under /arch/*/boot/dts/. Keeping each arch aligned is a pain.
>> > The dependencies and supported targets are all slightly different.
>> > Also, a cross-compiler for each arch is needed, but really the host
>> > compiler preprocessor is perfectly fine for building dtbs. Move the
>> > build rules to a common location and remove the arch specific ones. This
>> > is done in a single step to avoid warnings about overriding rules.
>> >
>> > The build dependencies had been a mixture of 'scripts' and/or 'prepare'.
>> > These pull in several dependencies some of which need a target compiler
>> > (specifically devicetable-offsets.h) and aren't needed to build dtbs.
>> > All that is really needed is dtc, so adjust the dependencies to only be
>> > dtc.
>> >
>> > This change enables support 'dtbs_install' on some arches which were
>> > missing the target.
>> >
>> > Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> > Cc: Michal Marek <michal.lkml@...kovi.net>
>> > Cc: Vineet Gupta <vgupta@...opsys.com>
>> > Cc: Russell King <linux@...linux.org.uk>
>> > Cc: Catalin Marinas <catalin.marinas@....com>
>> > Cc: Will Deacon <will.deacon@....com>
>> > Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> > Cc: Michal Simek <monstr@...str.eu>
>> > Cc: Ralf Baechle <ralf@...ux-mips.org>
>> > Cc: Paul Burton <paul.burton@...s.com>
>> > Cc: James Hogan <jhogan@...nel.org>
>> > Cc: Ley Foon Tan <lftan@...era.com>
>> > Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> > Cc: Paul Mackerras <paulus@...ba.org>
>> > Cc: Michael Ellerman <mpe@...erman.id.au>
>> > Cc: Chris Zankel <chris@...kel.net>
>> > Cc: Max Filippov <jcmvbkbc@...il.com>
>> > Cc: linux-kbuild@...r.kernel.org
>> > Cc: linux-snps-arc@...ts.infradead.org
>> > Cc: linux-arm-kernel@...ts.infradead.org
>> > Cc: uclinux-h8-devel@...ts.sourceforge.jp
>> > Cc: linux-mips@...ux-mips.org
>> > Cc: nios2-dev@...ts.rocketboards.org
>> > Cc: linuxppc-dev@...ts.ozlabs.org
>> > Cc: linux-xtensa@...ux-xtensa.org
>> > Signed-off-by: Rob Herring <robh@...nel.org>
>> > ---
>> > Please ack so I can take the whole series via the DT tree.
>> >
>> > v2:
>> >  - Fix $arch/boot/dts path check for out of tree builds
>> >  - Fix dtc dependency for building built-in dtbs
>> >  - Fix microblaze built-in dtb building
>>
>>
>> This breaks parallel building
>> because two threads could descend into scripts/dtc
>> at the same time.
>>
>> 'all' depends on both 'scripts' and 'dtc'.
>>
>> * 'scripts' target -- descends into scripts/, then scripts/dtc
>> * 'dtc' target     -- descents into scripts/dtc directly
>
> Any suggestions for how to fix given the problem with depending on
> scripts? I suppose I could make scripts depend on dtc instead, but I'd
> be back to needing to fix cleaning.

How about making 'prepare' depend on 'dtc'?

Then, remove
subdir-$(CONFIG_DTC)         += dtc
from scripts/Makefile

but, add dtc to subdir-


> Or I could just skip removing the
> cross compiler dependency for now.

I want to build scripts/
without target compiler.

modpost is a special host-program
that depends on $(CC).

I will take a look at it
when I find some time.


-- 
Best Regards
Masahiro Yamada