linux-kernel - Re: [PATCH] android:ion: the order and count are in the wrong position

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61e6a1ea-0c40-f191-2434-8086e035fed0@redhat.com>
Date:   Fri, 7 Sep 2018 09:58:53 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     jun qian <hangdianqj@....com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>
Cc:     devel@...verdev.osuosl.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
        Barry song <21cnbao@...il.com>
Subject: Re: [PATCH] android:ion: the order and count are in the wrong
 position

On 09/07/2018 08:20 AM, jun qian wrote:
> The value in the wrong position will cause misunderstanding,
> when the debug infomations display in the window.
> 

I think the existing order is okay, it's just not separated
well. It's "$count pages of order $order". I also just acked a
patch to remove all this code because it's dead on mainline
anyway. For future work, we should look to make the debugfs
output clearer to avoid ambiguity.

Thanks,
Laura

> Signed-off-by: jun qian <hangdianqj@....com>
> ---
>   drivers/staging/android/ion/ion_system_heap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index 701eb9f3b0f1..54b8a7710958 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -225,10 +225,10 @@ static int ion_system_heap_debug_show(struct ion_heap *heap, struct seq_file *s,
>   		pool = sys_heap->pools[i];
>   
>   		seq_printf(s, "%d order %u highmem pages %lu total\n",
> -			   pool->high_count, pool->order,
> +			   pool->order, pool->high_count,
>   			   (PAGE_SIZE << pool->order) * pool->high_count);
>   		seq_printf(s, "%d order %u lowmem pages %lu total\n",
> -			   pool->low_count, pool->order,
> +			   pool->order, pool->low_count,
>   			   (PAGE_SIZE << pool->order) * pool->low_count);
>   	}
>   
>