[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAOesGMiRYFuMDbs9bogSRz-85d_+JYh39ktvYeY2fuUL4Pmr6w@mail.gmail.com>
Date: Fri, 7 Sep 2018 10:14:31 -0700
From: Olof Johansson <olof@...om.net>
To: Sudeep Holla <sudeep.holla@....com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>,
Kevin Hilman <khilman@...aro.org>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] firmware: arm_scmi: use strlcpy to ensure NULL-terminated strings
Hi,
On Fri, Sep 7, 2018 at 9:52 AM, Sudeep Holla <sudeep.holla@....com> wrote:
> Replace all the memcpy() for copying name strings from the firmware with
> strlcpy() to make sure we are bounded by the source buffer size and we
> also always have NULL-terminated strings.
>
> This is needed to avoid out of bounds accesses if the firmware returns
> a non-terminated string.
>
> Reported-by: Olof Johansson <olof@...om.net>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
In case I don't end up applying it:
Acked-by: Olof Johansson <olof@...om.net>
> Let me know if this is rc/fix material or need to wait for v4.20 ?
I don't see a reason to merge this as a fix, it's more of a cleanup.
-Olof
Powered by blists - more mailing lists