linux-kernel - Re: [PATCH] asm-generic: bug: add unlikely() to BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 8 Sep 2018 07:32:15 +0300
From:   Igor Stoppa <igor.stoppa@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     igor.stoppa@...wei.com, linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] asm-generic: bug: add unlikely() to BUG_ON()



On 07/09/18 23:41, Arnd Bergmann wrote:

> Could you add a comment about -Wmaybe-uninitialized next to the definition?
> Otherwise that is easily lost.
> 
> Also, I see that the file has two separate definitions of BUG_ON(), and the
> other one does have an unlikely() in it already. Can you change both
> to do the same thing with unlikely() or not unlikely()?

ack

--
igor