linux-kernel - Re: [PATCH] xen/netfront: fix waiting for xenbus state change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180907.230348.33221589667753465.davem@davemloft.net>
Date:   Fri, 07 Sep 2018 23:03:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jgross@...e.com
Cc:     linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
        netdev@...r.kernel.org, boris.ostrovsky@...cle.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] xen/netfront: fix waiting for xenbus state change

From: Juergen Gross <jgross@...e.com>
Date: Fri,  7 Sep 2018 14:21:30 +0200

> Commit 822fb18a82aba ("xen-netfront: wait xenbus state change when load
> module manually") added a new wait queue to wait on for a state change
> when the module is loaded manually. Unfortunately there is no wakeup
> anywhere to stop that waiting.
> 
> Instead of introducing a new wait queue rename the existing
> module_unload_q to module_wq and use it for both purposes (loading and
> unloading).
> 
> As any state change of the backend might be intended to stop waiting
> do the wake_up_all() in any case when netback_changed() is called.
> 
> Fixes: 822fb18a82aba ("xen-netfront: wait xenbus state change when load module manually")
> Cc: <stable@...r.kernel.org> #4.18
> Signed-off-by: Juergen Gross <jgross@...e.com>

Applied.