linux-kernel - Re: [PATCH] Input: wm97xx: only unregister wm97xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 09 Sep 2018 21:08:53 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc:     Colin King <colin.king@...onical.com>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        Mark Brown <broonie@...nel.org>,
        "Mauro Carvalho Chehab" <mchehab+samsung@...nel.org>,
        <patches@...nsource.cirrus.com>, <linux-input@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered

Charles Keepax <ckeepax@...nsource.cirrus.com> writes:

> On Tue, Sep 04, 2018 at 07:35:05PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>> 
>> In the case where IS_BUILTIN(CONFIG_AC97_BUS)) is not true, the
>> wm97xx_driver driver is being unregistered even it has not been
>> previously registered.  Fix this by only unregistering it if
>> IS_BUILTIN(CONFIG_AC97_BUS)) is true.  This fixes the warning
>> message:
>> 
>> [  834.111248] ------------[ cut here ]------------
>> [  834.111248] Unexpected driver unregister!
>> [  834.111319] WARNING: CPU: 2 PID: 11749 at drivers/base/driver.c:193 driver_unregister+0x3b/0x40
>> [  834.111319] Modules linked in: wm97xx_ts(-) ....
>> 
>> ..and a stack trace.
>> 
>> To easily reproduce this, load and unload the module on a system where
>> the hardware is not supported.
>> 
>> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>
> Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Cheers.

-- 
Robert