linux-kernel - Re: [RFC][PATCH 3/8] x86/mm: break out user address space handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <029066e3-68e9-c6be-add2-a13b1c424818@linux.intel.com>
Date:   Mon, 10 Sep 2018 13:20:06 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, sean.j.christopherson@...el.com,
        tglx@...utronix.de, x86@...nel.org, luto@...nel.org
Subject: Re: [RFC][PATCH 3/8] x86/mm: break out user address space handling

On 09/08/2018 02:38 AM, Peter Zijlstra wrote:
>> +	/* Was the fault on kernel-controlled part of the address space? */
>> +	if (unlikely(fault_in_kernel_space(address)))
>> +		do_kern_addr_space_fault(regs, hw_error_code, address);
>> +	else
>> +		do_user_addr_space_fault(regs, hw_error_code, address);
>> +}
> How about: do_{user,kernel}_fault() ? That _addr_space_ is just a lot of
> typing for no real benefit imo.

Yeah, totally, the names are long.

I was just trying to make it obvious to differentiate address space from
*mode* when the fault occurred.  I can probably do that in comments
instead, though.