linux-kernel - Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5582ed9b297db98ddb713b240e6059acf26bb8a7.camel@perches.com>
Date:   Mon, 10 Sep 2018 14:22:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Dave Hansen <dave.hansen@...el.com>,
        sean.j.christopherson@...el.com, nhorman@...hat.com,
        npmccallum@...hat.com, linux-sgx@...r.kernel.org,
        serge.ayoun@...el.com, shay.katz-zamir@...el.com,
        "Siddha, Suresh B" <suresh.b.siddha@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers <ebiggers@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

On Mon, 2018-09-10 at 21:37 +0300, Jarkko Sakkinen wrote:
> On Thu, Sep 06, 2018 at 05:50:01PM -0700, Joe Perches wrote:
> > On Thu, 2018-09-06 at 19:35 +0200, Miguel Ojeda wrote:
> > > > Which one is right and why the kernel tree is polluted with C99-headers
> > > > when they do not pass checkpatch.pl?
> > 
> > checkpatch ignores c99 headers since 2016.
> 
> For headers I get these warnings:
> 
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #243: FILE: drivers/platform/x86/intel_sgx/sgx.h:1:
> +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)

Because .h files are supposed to use /* */