linux-kernel - Re: [PATCH v4 6/8] usb: dwc3: check for requests in started list for stream capable endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 22:50:44 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Thinh.Nguyen@...opsys.com" <Thinh.Nguyen@...opsys.com>,
        "v.anuragkumar@...il.com" <v.anuragkumar@...il.com>
Subject: Re: [PATCH v4 6/8] usb: dwc3: check for requests in started list
 for stream capable endpoints

Hi,

On 9/10/2018 1:13 PM, Thinh Nguyen wrote:
> Hi Anurag,
>
> On 9/8/2018 8:03 AM, Anurag Kumar Vulisha wrote:
>> For stream capable endpoints, uas layer can queue mulpile requests on
>> single ep with different stream ids. So, there can be multiple pending
>> requests waiting to be transferred. This patch changes the code to check
>> for any pending requests waiting to be transferred on ep started_list and
>> calls __dwc3_gadget_kick_transfer() if any.
> Whenever a function driver queues a request, then
> __dwc3_gadget_kick_transfer() will be called right? What case exactly is
> this for? Scatter gathering? If so, then we probably need further
> explanation. (e.g. Why wait to call __dwc3_gadget_kick_transfer() on
> XferComplete event rather than sending a START_TRANSFER command for
> every prepared TRB whenever we do __dwc3_gadget_kick_transfer()?).

Please ignore my question.  We only do 1 transfer per stream id at a
time. That's fine.

Thanks,
Thinh