linux-kernel - [PATCH 0/3] libnvdimm: reset seeds for next namespace creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1536560508-24564-1-git-send-email-oceanhehy@gmail.com>
Date:   Mon, 10 Sep 2018 02:21:45 -0400
From:   Ocean He <oceanhehy@...il.com>
To:     dan.j.williams@...el.com, zwisler@...nel.org,
        vishal.l.verma@...el.com, dave.jiang@...el.com
Cc:     linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org,
        Ocean He <hehy1@...ovo.com>
Subject: [PATCH 0/3] libnvdimm: reset seeds for next namespace creation 

From: Ocean He <hehy1@...ovo.com>

When pmem namespaces created are smaller than section size twice, the
second creation would fail and meanwhile there is a kernel call trace
which comes from commit 15d36fecd0bdc7510b70 ("mm: disallow mappings that
conflict for devm_memremap_pages()").
	------------[ cut here ]------------
	nd_pmem pfn1.1: Conflicting mapping in same section
	WARNING: CPU: 84 PID: 51974 at kernel/memremap.c:194 devm_memremap_pages+0x4a0/0x4e0
	CPU: 84 PID: 51974 Comm: ndctl Kdump: loaded Tainted: G W E 4.19.0-rc2-23-default+ #27
	RIP: 0010:devm_memremap_pages+0x4a0/0x4e0
	Call Trace:
	 pmem_attach_disk+0x3ab/0x581 [nd_pmem]
	 nvdimm_bus_probe+0x69/0x150 [libnvdimm]
	 really_probe+0x262/0x3d0
	 driver_probe_device+0x60/0x120
	 bind_store+0x102/0x190
	 kernfs_fop_write+0x105/0x180
	 __vfs_write+0x36/0x1a0
	 ? common_file_perm+0x47/0x130
	 ? security_file_permission+0x2c/0xb0
	 vfs_write+0xad/0x1a0
	 ksys_write+0x52/0xc0
	 do_syscall_64+0x5b/0x180
	 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Here is an example (section size is 128MB) based on kernel 4.19-rc2.
	# ndctl create-namespace -r region1 -s 100m -t pmem -m fsdax
	{
	  "dev":"namespace1.0",
	  "mode":"fsdax",
	  "map":"dev",
	  "size":"96.00 MiB (100.66 MB)",
	  "uuid":"ef9a0556-a610-40b5-8c71-43991765a2cc",
	  "raw_uuid":"177b22e2-b7e8-482f-a063-2b8de876d979",
	  "sector_size":512,
	  "blockdev":"pmem1",
	  "numa_node":1
	}
	# ndctl create-namespace -r region1 -s 100m -t pmem -m fsdax
	libndctl: ndctl_pfn_enable: pfn1.1: failed to enable
	  Error: namespace1.1: failed to enable
	failed to create namespace: No such device or address

When above second creation failure occurs, the expectation is to destroy
namespace1.0 to create a new namespace which size is aligned with section
size. However, both namespace seed and pfn seed have been consumed, the
new namespace creation still fails.
	# ndctl destroy-namespace namespace1.0 -f
	destroyed 1 namespace
	# ndctl create-namespace -r region1 -s 128m -t pmem -m fsdax
	failed to create namespace: Device or resource busy

To ensure pfn_seed/dax_seed and namespace_seed are always ready for next
namespace creation, this patch set enables seed detach and reset. Back to
the example, the new namespace creation never fails if this patch set
applied.
	# ndctl destroy-namespace namespace1.0 -f
	destroyed 1 namespace
	# ndctl create-namespace -r region1 -s 128m -t pmem -m fsdax
	{
	  "dev":"namespace1.0",
	  "mode":"fsdax",
	  "map":"dev",
	  "size":"124.00 MiB (130.02 MB)",
	  "uuid":"0d0e7506-d108-4a88-824a-edef26fd0399",
	  "raw_uuid":"efeb9647-12f5-44cd-8a52-2f3a0d14589a",
	  "sector_size":512,
	  "blockdev":"pmem1",
	  "numa_node":1
	}
	# ndctl create-namespace -r region1 -s 128m -t pmem -m fsdax
	{
 	  "dev":"namespace1.1",
 	  "mode":"fsdax",
 	  "map":"dev",
 	  "size":130023424,
 	  "uuid":"689828dc-8779-434d-8e93-0406d4e1e536",
 	  "raw_uuid":"d86e1025-c224-48b6-b2a7-6ccef152d5fd",
 	  "sector_size":512,
 	  "blockdev":"pmem1.1",
 	  "numa_node":1
	}

The mode devdax (-m devdax) has the same issue, this patch set could
cover it.

Ocean He (3):
  libnvdimm, claim: remove static attribute of nd_detach_and_reset
  libnvdimm, namespace_devs: add function nd_region_reset_ns_seed for
    namespace seed reset
  libnvdimm, region_devs: reset related seeds when fail to create
    namespace

 drivers/nvdimm/claim.c          |  2 +-
 drivers/nvdimm/namespace_devs.c | 32 ++++++++++++++++++++++++++++++++
 drivers/nvdimm/nd-core.h        |  2 ++
 drivers/nvdimm/region_devs.c    | 34 ++++++++++++++++++++++++++++++++++
 4 files changed, 69 insertions(+), 1 deletion(-)

-- 
1.8.3.1