linux-kernel - Re: [RFC][PATCH 1/8] start unifying termios convertors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 09:32:34 +0100
From:   David Howells <dhowells@...hat.com>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     dhowells@...hat.com, linux-arch@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 1/8] start unifying termios convertors

Al Viro <viro@...IV.linux.org.uk> wrote:

> +static inline int kernel_termios_to_user_termios(struct termios2 __user *u,
> +						 struct ktermios *k)
> +{
> +	int err;
> +	err  = put_user(k->c_iflag, &u->c_iflag);
> +	err |= put_user(k->c_oflag, &u->c_oflag);
> +	err |= put_user(k->c_cflag, &u->c_cflag);
> +	err |= put_user(k->c_lflag, &u->c_lflag);
> +	err |= put_user(k->c_line, &u->c_line);
> +	err |= copy_to_user(u->c_cc, k->c_cc, NCCS);
> +	if (!(k->c_lflag & ICANON)) {
> +		err |= put_user(k->c_cc[VMIN],  &u->c_cc[_VMIN]);
> +		err |= put_user(k->c_cc[VTIME], &u->c_cc[_VTIME]);
> +	} else {
> +		err |= put_user(k->c_cc[VEOF], &u->c_cc[VEOF]);
> +		err |= put_user(k->c_cc[VEOL], &u->c_cc[VEOL]);
> +	}
> +	err |= put_user(k->c_ispeed, &u->c_ispeed);
> +	err |= put_user(k->c_ospeed, &u->c_ospeed);
> +	return err;
> +}

Can you make this use || instead of |= ?  That way if put_user() uses a
goto-out-of-asm it may be a lot more efficient, both in the normal case and
the error case.

David