linux-kernel - Re: [PATCH] bcache: remove redundant condition before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 08:50:11 +0800
From:   Junhui Tang <tang.junhui.linux@...il.com>
To:     zhongjiang@...wei.com
Cc:     colyli@...e.de, Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: remove redundant condition before debugfs_remove

LGTM

Reviewed-by: tang.junhui.linux@...il.com
zhong jiang <zhongjiang@...wei.com> 于2018年9月8日周六 下午9:08写道：
>
> debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/md/bcache/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 2d26f9e..a3d2a94 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1506,8 +1506,7 @@ static void cache_set_free(struct closure *cl)
>         struct cache *ca;
>         unsigned int i;
>
> -       if (!IS_ERR_OR_NULL(c->debug))
> -               debugfs_remove(c->debug);
> +       debugfs_remove(c->debug);
>
>         bch_open_buckets_free(c);
>         bch_btree_cache_free(c);
> --
> 1.7.12.4
>