linux-kernel - Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 12:23:37 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     sed@...e.fr
Cc:     kgene@...nel.org, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect
 detection on Mini2440

On Fri, 7 Sep 2018 at 23:53, Cedric Roux <sed@...e.fr> wrote:
>
> The mini2440 computer uses "active high" to signal that the "write protect"
> of the inserted MMC is set. The current code uses the opposite, leading to
> a wrong detection of write protection. The solution is simply to use
> ".wprotect_invert = 1" in the description of the MMC.
>
> Signed-off-by: Cedric Roux <sed@...e.fr>
> ---
>  arch/arm/mach-s3c24xx/mach-mini2440.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
> index 4a0bf6abba8c..bfce7971d741 100644
> --- a/arch/arm/mach-s3c24xx/mach-mini2440.c
> +++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
> @@ -234,10 +234,11 @@ static struct s3c2410fb_mach_info mini2440_fb_info __initdata = {
>  /* MMC/SD  */
>
>  static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = {
> -       .gpio_detect   = S3C2410_GPG(8),
> -       .gpio_wprotect = S3C2410_GPH(8),
> -       .set_power     = NULL,
> -       .ocr_avail     = MMC_VDD_32_33|MMC_VDD_33_34,
> +       .gpio_detect     = S3C2410_GPG(8),
> +       .gpio_wprotect   = S3C2410_GPH(8),
> +       .wprotect_invert = 1,
> +       .set_power       = NULL,
> +       .ocr_avail       = MMC_VDD_32_33|MMC_VDD_33_34,

This looks unexpected... after patch 1 there should be only one change
- one new line added. What happened here?

Best regards,
Krzysztof