linux-kernel - Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910112418.GB12979@infradead.org>
Date:   Mon, 10 Sep 2018 04:24:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Atish Patra <atish.patra@....com>
Cc:     palmer@...ive.com, linux-riscv@...ts.infradead.org,
        hch@...radead.org, anup@...infault.org, mark.rutland@....com,
        Damien.LeMoal@....com, jason@...edaemon.net,
        ard.biesheuvel@...aro.org, marc.zyngier@....com,
        gregkh@...uxfoundation.org, dmitriy@...-tech.org,
        linux-kernel@...r.kernel.org, jeremy.linton@....com,
        catalin.marinas@....com, tglx@...utronix.de
Subject: Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

On Thu, Sep 06, 2018 at 01:05:25AM -0700, Atish Patra wrote:
> +#elif defined(CONFIG_64BIT)
> +	if ((strcmp(mmu_type, "riscv,sv39") != 0)
> +	    && (strcmp(mmu_type, "riscv,sv48") != 0))
> +		return;

This should be:

	if (strcmp(mmu_type, "riscv,sv39") != 0 &&
	    strcmp(mmu_type, "riscv,sv48") != 0)
		return;

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>