linux-kernel - Re: [PATCH v2] asm-generic: bug: unify hints for BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a02Q0_r4sqzJzA01GEHf0oUyevwwVg+E0_iCEkLFrwOaw@mail.gmail.com>
Date:   Mon, 10 Sep 2018 14:16:52 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Igor Stoppa <igor.stoppa@...il.com>
Cc:     igor.stoppa@...wei.com, linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] asm-generic: bug: unify hints for BUG_ON()

On Sat, Sep 8, 2018 at 6:59 AM Igor Stoppa <igor.stoppa@...il.com> wrote:
>
> If BUG_ON() is used instead of BUG(), it means that probably the
> preferred outcome is to not BUG(), therefore the condition tested should
> be unlikely().
>
> However, when CONFIG_PROFILE_ANNOTATED_BRANCHES is enabled, the hint is
> disabled, to avoid generating false-positive warnings caused by
> -Wmaybe-uninitialized.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: linux-arch@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---

Acked-by: Arnd Bergmann <arnd@...db.de>

I assume this will be included in a longer patch series rather than
going through
my asm-generic tree, right?

     Arnd