linux-kernel - Re: [PATCH] Revert "x86/tsc: Consolidate init code"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1809101443290.1292@nanos.tec.linutronix.de>
Date:   Mon, 10 Sep 2018 14:48:45 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Ville Syrjala <ville.syrjala@...ux.intel.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Dou Liyang <douly.fnst@...fujitsu.com>,
        Pavel Tatashin <pasha.tatashin@...rosoft.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code"

Ville,

On Mon, 10 Sep 2018, Ville Syrjala wrote:

> From: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> 
> This reverts commit 608008a45798fe9e2aee04f99b5270ea57c1376f.
> 
> It breaks wifi on my pentium 3 Fujitsu-Siemens Lifebook S6010
> laptop. Scanning for APs doesn't seem to work most of the time,
> and, even when it manages to find some APs it never manages to
> authenticate successfully. dmesg is just littered with:
> "wlan0: send auth to ... (try 1/3)
>  wlan0: send auth to ... (try 2/3)
>  wlan0: send auth to ... (try 3/3)
>  wlan0: authentication with ... timed out"

I asked for that before and I really do not understand why you do not even
make an attempt to report an issue first and allow the developers to work
with you to figure out what exactly is the problem. All you do is to send
an revert patch with a changelog which describes symptoms and probably
breaks more than it cures. Not really helpful, really.

It's surely helpful to know that you bisected it to that commit and
reverting it helps. Can you please provide more detailes information like
dmesg of an good and a bad boot?

Thanks,

	tglx