linux-kernel - Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea441610-1337-d14c-7171-f0fac158bd9a@sorico.fr>
Date:   Mon, 10 Sep 2018 15:19:58 +0200
From:   Richard Genoud <richard.genoud@...il.com>
To:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        linux-serial@...r.kernel.org, linux-arch@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     gregkh@...uxfoundation.org, jslaby@...e.com, arnd@...db.de,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

Hi, Ludovic,

On 06/09/2018 15:42, Ludovic Desroches wrote:
> From: Nicolas Ferre <nicolas.ferre@...rochip.com>
> 
> When mode is set in atmel_config_iso7816() we backup last RS232 mode
> for coming back to this mode if requested.
> Also allow setup of T=0 and T=1 parameter and basic support in set_termios
> function as well.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
> [ludovic.desroches@...rochip.com: rebase, add check on fidi ratio, checkpatch fixes]
> Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

This seems ok for me.

Acked-by: Richard Genoud <richard.genoud@...il.com>

Thanks !