linux-kernel - Re: [PATCH] Drivers: hv: vmbus: include header for get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910140658.4umofqptuxhevtit@linutronix.de>
Date:   Mon, 10 Sep 2018 16:06:58 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>
Cc:     devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Bernhard Landauer <oberon@...jaro.org>,
        Ralf Ramsauer <ralf.ramsauer@...-regensburg.de>
Subject: Re: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()

On 2018-08-30 09:55:03 [+0200], To K. Y. Srinivasan wrote:
> On !RT the header file get_irq_regs() gets pulled in via other header files. On
> RT it does not and the build fails:
> 
>     drivers/hv/vmbus_drv.c:975 implicit declaration of function ‘get_irq_regs’ [-Werror=implicit-function-declaration]
>     drivers/hv/hv.c:115 implicit declaration of function ‘get_irq_regs’ [-Werror=implicit-function-declaration]
> 
> Add the header file for get_irq_regs() in a common header so it used by
> vmbus_drv.c by hv.c for their get_irq_regs() usage.
> 
> Reported-by: Bernhard Landauer <oberon@...jaro.org>
> Reported-by: Ralf Ramsauer <ralf.ramsauer@...-regensburg.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

ping

> ---
>  drivers/hv/hyperv_vmbus.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 72eaba3d50fc2..797f07918197c 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -31,6 +31,7 @@
>  #include <linux/atomic.h>
>  #include <linux/hyperv.h>
>  #include <linux/interrupt.h>
> +#include <linux/irq.h>
>  
>  #include "hv_trace.h"
>  
> -- 
> 2.18.0
>