linux-kernel - Re: [PATCH] perf test: Add watchpoint test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910141830.GI5147@kernel.org>
Date:   Mon, 10 Sep 2018 11:18:30 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        tmricht@...ux.ibm.com, sandipan@...ux.ibm.com,
        brueckner@...ux.ibm.com, kim.phillips@....com,
        kstewart@...uxfoundation.org, tglx@...utronix.de,
        naveen.n.rao@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf test: Add watchpoint test

Em Mon, Sep 10, 2018 at 10:47:54AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Sep 10, 2018 at 12:31:54PM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 10, 2018 at 03:28:11PM +0530, Ravi Bangoria wrote:
> > > We don't have perf test available to test watchpoint functionality.
> > > Add simple set of tests: 
> > >  - Read only watchpoint
> > >  - Write only watchpoint
> > >  - Read / Write watchpoint
> > >  - Runtime watchpoint modification
> > > 
> > > Ex on powerpc:
> > >   $ sudo ./perf test 22
> > >   22: Watchpoint                                            :
> > >   22.1: Read Only Watchpoint                                : Ok
> > >   22.2: Write Only Watchpoint                               : Ok
> > >   22.3: Read / Write Watchpoint                             : Ok
> > >   22.4: Modify Watchpoint                                   : Ok
> > 
> > cool, thanks!
> > 
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Thanks, applied.

While testing, I got curious, as a 'perf test' user, why one of the
tests had the "Skip" result:

[root@...enth ~]# perf test watchpoint
22: Watchpoint                                            :
22.1: Read Only Watchpoint                                : Skip
22.2: Write Only Watchpoint                               : Ok
22.3: Read / Write Watchpoint                             : Ok
22.4: Modify Watchpoint                                   : Ok
[root@...enth ~]#

I tried with 'perf test -v watchpoint' but that didn't help, perhaps you
could add some message after the "Skip" telling why it skipped that
test? I.e. hardware doesn't have that capability, kernel driver not yet
supporting that, something else?

- Arnaldo