linux-kernel - Re: mfd: cros_ec: Check for mkbp events on resume only if supported.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180910143744.GT28860@dell>
Date:   Mon, 10 Sep 2018 15:37:44 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     RaviChandra Sadineni <ravisadineni@...omium.org>
Cc:     dmitry.torokhov@...il.com, ravisadineni@...gle.com,
        dtor@...gle.com, linux-samsung-soc@...r.kernel.org,
        tbroch@...gle.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org, tfiga@...omium.org,
        m.szyprowski@...sung.com
Subject: Re: mfd: cros_ec: Check for mkbp events on resume only if supported.

On Mon, 20 Aug 2018, RaviChandra Sadineni wrote:

> Currently on every resume we check for mkbp events and notify the
> clients. This helps in identifying the wakeup sources. But on devices
> that do not support mkbp protocol, we might end up querying key state of
> the keyboard in a loop which blocks the resume. Instead check for events
> only if mkbp is supported.
> 
> Signed-off-by: RaviChandra Sadineni <ravisadineni@...omium.org>
> ---
> 
>  Note: This patch fixes the suspend/resume issue on Snow and Peach-Pit
>  Chromebooks, both on vanilla v4.18 as well as linux-next from 20 August 
>  2018. Further info at: https://lkml.org/lkml/2018/6/5/1076
>  
>  drivers/mfd/cros_ec.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog