linux-kernel - Re: [PATCH v6 3/3] staging: mt7621-mmc: Fix debug macro IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910150513.GA25530@kroah.com>
Date:   Mon, 10 Sep 2018 17:05:13 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        NeilBrown <neil@...wn.name>, Joe Perches <joe@...ches.com>,
        Christian Lütke-Stetzkamp <christian@...mp.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        John Crispin <blogic@...nwrt.org>
Subject: Re: [PATCH v6 3/3] staging: mt7621-mmc: Fix debug macro IRQ_MSG and
 its usages

On Sat, Sep 01, 2018 at 03:51:10AM +0530, Nishad Kamdar wrote:
> Replace all usages of IRQ_MSG with with dev_<level> without __func__
> or __LINE__ or current->comm and current->pid. Remove the do {}
> while(0) loop for the single statement macro. Drop IRQ_MSG from dbg.h.
> Issue found by checkpatch.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
> Changes in v6:
>   - No change
> Changes in v5:
>   - No change
> ---
>  drivers/staging/mt7621-mmc/dbg.h | 12 -----------
>  drivers/staging/mt7621-mmc/sd.c  | 36 ++++++++++++++++++++++++--------
>  2 files changed, 27 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/dbg.h
> index 79914d98c573..4ab9f10dccc2 100644
> --- a/drivers/staging/mt7621-mmc/dbg.h
> +++ b/drivers/staging/mt7621-mmc/dbg.h
> @@ -102,18 +102,6 @@ do { \
>  } while (0)
>  #endif /* end of +++ */
>  
> -#if 1
> -//defined CONFIG_MTK_MMC_CD_POLL
> -#define IRQ_MSG(fmt, args...)

So right now this define does nothing, yet:

> -#else
> -/* PID in ISR in not corrent */
> -#define IRQ_MSG(fmt, args...) \
> -do { \
> -	printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d>\n",	\
> -	       host->id,  ##args, __FUNCTION__, __LINE__);	\
> -} while (0);
> -#endif
> -
>  void msdc_debug_proc_init(void);
>  
>  #if 0 /* --- chhung */
> diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> index 7474f9ed7b5b..f3ae19fe0f76 100644
> --- a/drivers/staging/mt7621-mmc/sd.c
> +++ b/drivers/staging/mt7621-mmc/sd.c
> @@ -279,7 +279,9 @@ static void msdc_tasklet_card(struct work_struct *work)
>  		mmc_detect_change(host->mmc, msecs_to_jiffies(20));
>  	}
>  
> -	IRQ_MSG("card found<%s>", inserted ? "inserted" : "removed");
> +	dev_err(mmc_dev(host->mmc),
> +		"%d -> card found<%s>\n",
> +		host->id, inserted ? "inserted" : "removed");

You are now printing out lots of "errors" that really are not errors.

As these messages are not being printed at all right now, why not just
delete these as well?

Your first 2 patches do look good, I've queued them up now.

thanks,

greg k-h