linux-kernel - Re: [PATCH v2] mfd: madera: Don't use regmap_read_poll_timeout to poll for BOOT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180910152253.GY28860@dell>
Date:   Mon, 10 Sep 2018 16:22:53 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: madera: Don't use regmap_read_poll_timeout to
 poll for BOOT_DONE

On Mon, 27 Aug 2018, Richard Fitzgerald wrote:

> While polling for BOOT_DONE the chip could NAK a read because it is
> still booting, which would terminate the regmap_read_poll_timeout()
> with an error.
> 
> Instead implement a polling loop that ignores read errors so we
> always poll until the chip signals boot or the loop times out.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> ---
>  drivers/mfd/madera-core.c | 33 ++++++++++++++++++++-------------
>  1 file changed, 20 insertions(+), 13 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog