linux-kernel - Re: [PATCH] mfd: mc13xxx-core: Fix PMIC shutdown when reading ADC values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180910152905.GB28860@dell>
Date:   Mon, 10 Sep 2018 16:29:05 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-kernel@...r.kernel.org, u.kleine-koenig@...gutronix.de,
        andrey.gusakov@...entembedded.com, cphealy@...il.com,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH] mfd: mc13xxx-core: Fix PMIC shutdown when reading ADC
 values

On Tue, 28 Aug 2018, Fabio Estevam wrote:

> From: Fabio Estevam <fabio.estevam@....com>
> 
> When trying to read any MC13892 ADC channel on a imx51-babbage board:
> 
> # cat /sys/class/hwmon/hwmon0/device/in7_input
> 
> The MC13892 PMIC shutdowns completely.
> 
> After debugging this issue and comparing the MC13892 and MC13783
> initializations done in the vendor kernel, it was noticed that the
> CHRGRAWDIV bit of the ADC0 register was not being set.
> 
> This bit is set by default after power on, but the driver was
> clearing it.
> 
> After setting this bit it is possible to read the ADC values correctly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>
> ---
>  drivers/mfd/mc13xxx-core.c  | 3 ++-
>  include/linux/mfd/mc13xxx.h | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog