linux-kernel - Re: [RFC PATCH linux-next] btrfs: btrfs_run_delayed_refs_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180910164843.GS24025@twin.jikos.cz>
Date:   Mon, 10 Sep 2018 18:48:43 +0200
From:   David Sterba <dsterba@...e.cz>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Nikolay Borisov <nborisov@...e.com>, kbuild-all@...org,
        David Sterba <dsterba@...e.com>,
        Chris Mason <chris.mason@...ionio.com>,
        Josef Bacik <jbacik@...com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH linux-next] btrfs: btrfs_run_delayed_refs_for_head()
 can be static

On Mon, Sep 10, 2018 at 11:00:29PM +0800, kbuild test robot wrote:
> 
> Fixes: ac75a14eb672 ("btrfs: Factor out loop processing all refs of a head")
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> ---
>  extent-tree.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index b0882b6..719f1bb 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2537,9 +2537,9 @@ struct btrfs_delayed_ref_head *btrfs_obtain_ref_head(
>  }
>  
>  STATIC
> -int btrfs_run_delayed_refs_for_head(struct btrfs_trans_handle *trans,
> -				    struct btrfs_delayed_ref_head *locked_ref,
> -				    unsigned long *run_refs)
> +static int btrfs_run_delayed_refs_for_head(struct btrfs_trans_handle *trans,
> +					   struct btrfs_delayed_ref_head *locked_ref,
> +					   unsigned long *run_refs)

I have a cleanup series to get rid of the STATIC macro, will result in
normal 'static' of the function. The patch will need to be updated, you
can ignore the warning for now.

>  {
>  	struct btrfs_fs_info *fs_info = trans->fs_info;
>  	struct btrfs_delayed_ref_root *delayed_refs;