linux-kernel - Re: [PATCH v3] staging: erofs: use explicit unsigned int type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3369321-d5b5-4b9e-87e4-b8ce341ec5e3@t-8ch.de>
Date:   Mon, 10 Sep 2018 21:15:28 +0200
From:   Thomas Weißschuh <linux@...ssschuh.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Gao Xiang <gaoxiang25@...wei.com>, Chao Yu <yuchao0@...wei.com>,
        linux-erofs@...ts.ozlabs.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: erofs: use explicit unsigned int type

Hi Greg,

On Mon, 2018-09-10T10:10+0200, Greg Kroah-Hartman wrote:
> On Sun, Sep 09, 2018 at 08:37:53PM +0200, Thomas Weißschuh wrote:
> > Changes since v1:
> > 
> > * Removed changes that conflicted with
> >   [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c
> > * Added patch description
> > 
> > Changes since v2:
> > 
> > * Fixed conflicts with other patchsets
> > * Don't introduce new style issues
> > 
> 
> These changes belong below the --- line, not above it.  I'm not sure if
> git will handle this line:

> 
> > -- >8 --

The patch was supposed to be applied with "git am --scissors".
To be honest, I am not sure if the scissors feature of git is to be used for
kernel development, or if I should have announced it.
If is not applicable I will be happy to resend the patch in another format.

The documentation for git-mailinfo(1) sounded it would fit my usecase perfectly:

   ...
   This is useful if you want to begin your message in a discussion thread with comments and suggestions on the message you are responding to, and to conclude it with a
   patch submission, separating the discussion and the beginning of the proposed commit log message with a scissors line.
   ...

> Correctly or not, have you tried it?

I tried to both apply and compile the patch, both succeeded.

Thomas