linux-kernel - Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180911073922.GG2494@piout.net>
Date:   Tue, 11 Sep 2018 09:39:22 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Jeremy Gebben <jgebben@...ptlaser.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

On 10/09/2018 16:20:19-0700, Guenter Roeck wrote:
> > +static int abx80x_wdog_set_timeout(struct watchdog_device *wdog,
> > +				unsigned int new_timeout)
> 
> I'll leave multi-line alignment issues to the driver maintainer.
> 

Indeed, I'd like those to be aligned on the parenthesis.

Thank you for your review.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com