linux-kernel - Re: [PATCH 2/5] dma-mapping: move the dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180911081952.GA17267@kroah.com>
Date:   Tue, 11 Sep 2018 10:19:52 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     iommu@...ts.linux-foundation.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Robin Murphy <robin.murphy@....com>,
        Paul Burton <paul.burton@...s.com>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] dma-mapping: move the dma_coherent flag to struct
 device

On Tue, Sep 11, 2018 at 08:46:36AM +0200, Christoph Hellwig wrote:
> On Mon, Sep 10, 2018 at 06:13:50PM +0200, Greg Kroah-Hartman wrote:
> > > +#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \
> > > +    defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \
> > > +    defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL)
> > > +	bool			dma_coherent:1;
> > > +#endif
> > 
> > It's just one bit, why not always have it enabled here?  If the arch
> > uses it or doesn't, no big deal.
> > 
> > Or are you using this to "catch" arches that mess something up?
> 
> Yes, that is the intent - I don't want architectures to accidentally
> set it while not selecting the non-coherent infrastructure, as it
> won't have an effect.

Ok, fine with me:
	Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>