linux-kernel - Re: [PATCH v2] x86/paravirt: Cleanup native

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb3dd51b-1807-b5ea-58c6-714fdee7f173@suse.com>
Date:   Tue, 11 Sep 2018 11:44:26 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v2] x86/paravirt: Cleanup native_patch()

On 11/09/18 11:15, Borislav Petkov wrote:
> When CONFIG_PARAVIRT_SPINLOCKS=n, it fires
> 
>   arch/x86/kernel/paravirt_patch_64.c: In function ‘native_patch’:
>   arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ‘patch_site’ defined but not used [-Wunused-label]
>    patch_site:
> 
> but those labels can simply be removed by directly calling the
> respective functions there.
> 
> Get rid of local variables too, while at it. Also, simplify function
> flow for better readability.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: x86@...nel.org
> Cc: virtualization@...ts.linux-foundation.org

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen