linux-kernel - Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4633e2a9-868c-40bb-a6b3-366842c93f0a@wdc.com>
Date:   Mon, 10 Sep 2018 18:35:03 -0700
From:   Atish Patra <atish.patra@....com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "palmer@...ive.com" <palmer@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Damien Le Moal <Damien.LeMoal@....com>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "dmitriy@...-tech.org" <dmitriy@...-tech.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jeremy.linton@....com" <jeremy.linton@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>
Subject: Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

On 9/10/18 4:24 AM, Christoph Hellwig wrote:
> On Thu, Sep 06, 2018 at 01:05:25AM -0700, Atish Patra wrote:
>> +#elif defined(CONFIG_64BIT)
>> +	if ((strcmp(mmu_type, "riscv,sv39") != 0)
>> +	    && (strcmp(mmu_type, "riscv,sv48") != 0))
>> +		return;
> 
> This should be:
> 
> 	if (strcmp(mmu_type, "riscv,sv39") != 0 &&
> 	    strcmp(mmu_type, "riscv,sv48") != 0)
> 		return;
> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 

Fixed.

Regards,
Atish