linux-kernel - Re: [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Sep 2018 18:36:52 -0700
From:   Atish Patra <atish.patra@....com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "palmer@...ive.com" <palmer@...ive.com>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Damien Le Moal <Damien.LeMoal@....com>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "dmitriy@...-tech.org" <dmitriy@...-tech.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jeremy.linton@....com" <jeremy.linton@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>
Subject: Re: [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to
 riscv_of_processor_hartid

On 9/10/18 4:26 AM, Christoph Hellwig wrote:
> On Thu, Sep 06, 2018 at 01:05:29AM -0700, Atish Patra wrote:
>> From: Palmer Dabbelt <palmer@...ive.com>
>>
>> It's a bit confusing exactly what this function does: it actually
>> returns the hartid of an OF processor node, failing with -1 on invalid
>> nodes.  I've changed the name to _hartid() in order to make that a bit
>> more clear, as well as adding a comment.
>>
>> Signed-off-by: Palmer Dabbelt <palmer@...ive.com>
> 
> Looks generally good, but it is going to conflict with the dt iterators
> series from Rob.  Given that this is just a little cleanup it might be
> worth deferring until the next merge window.
> 

Sure. np. I guess the entire series can be parked in for-next until the 
next merge window opens.

Regards,
Atish
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
>