linux-kernel - Re: [PATCH] Iommu: ipmmu-vmsa: replace spin_lock_irqsave with spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWjKLqRPW=mUEk8LxWoSQSgw25p60PPL9WE=d12YfD-4g@mail.gmail.com>
Date:   Tue, 11 Sep 2018 17:11:34 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     hangdianqj@....com
Cc:     Joerg Roedel <joro@...tes.org>,
        Linux IOMMU <iommu@...ts.linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Magnus Damm <magnus.damm@...il.com>
Subject: Re: [PATCH] Iommu: ipmmu-vmsa: replace spin_lock_irqsave with
 spin_lock in ISR

CC linux-renesas-soc

On Tue, Sep 11, 2018 at 5:01 PM jun qian <hangdianqj@....com> wrote:
>
> As you are already in ISR, it is unnecessary to call spin_lock_irqsave.
>
> Signed-off-by: jun qian <hangdianqj@....com>
> ---
>  drivers/iommu/ipmmu-vmsa.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
> index 22b94f8a9a04..afa23d53502c 100644
> --- a/drivers/iommu/ipmmu-vmsa.c
> +++ b/drivers/iommu/ipmmu-vmsa.c
> @@ -569,9 +569,8 @@ static irqreturn_t ipmmu_irq(int irq, void *dev)
>         struct ipmmu_vmsa_device *mmu = dev;
>         irqreturn_t status = IRQ_NONE;
>         unsigned int i;
> -       unsigned long flags;
>
> -       spin_lock_irqsave(&mmu->lock, flags);
> +       spin_lock(&mmu->lock);
>
>         /*
>          * Check interrupts for all active contexts.
> @@ -583,7 +582,7 @@ static irqreturn_t ipmmu_irq(int irq, void *dev)
>                         status = IRQ_HANDLED;
>         }
>
> -       spin_unlock_irqrestore(&mmu->lock, flags);
> +       spin_unlock(&mmu->lock);
>
>         return status;
>  }
> --
> 2.17.1