linux-kernel - Re: [REGRESSION] bfq probe failed on 4.19-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd71494f-4595-7586-4c46-000f2b2029aa@kernel.dk>
Date:   Tue, 11 Sep 2018 10:49:05 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Jeff Moyer <jmoyer@...hat.com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        Paolo Valente <paolo.valente@...aro.org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION] bfq probe failed on 4.19-rc3

On 9/11/18 10:48 AM, Jeff Moyer wrote:
> Jens Axboe <axboe@...nel.dk> writes:
> 
>> On 9/11/18 10:03 AM, Takashi Iwai wrote:
>>> Hi,
>>>
>>> I noticed that bfq doesn't appear in the I/O scheduler list on
>>> 4.19-rc3.  It seems that blkcg_policy_register() at the beginning of
>>> bfq_init() returns -ENOSPC, hence the probe aborts silently.
>>>
>>> Is this already addressed?
>>
>> Haven't heard about this one before. What kernel did you last use that
>> worked?
> 
> I'm guessing you just need to update the maximum number of policies:
> 
> /*
>  * Maximum number of blkcg policies allowed to be registered concurrently.
>  * Defined here to simplify include dependency.
>  */
> #define BLKCG_MAX_POLS          3

That is my guess too, hence the suggestion to try and disable the
iolatency policy. Just tried here without, and it works, rebooting
with to verify that we're running out of policy slots.

-- 
Jens Axboe